Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:dialog boxes extending beyond the window #1446

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix:dialog boxes extending beyond the window #1446

merged 2 commits into from
Oct 17, 2024

Conversation

maoguy
Copy link
Contributor

@maoguy maoguy commented Oct 17, 2024

#1422

fix the overflow bug of Message component

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working frontend Pertains to the frontend. labels Oct 17, 2024
@dokterbob dokterbob enabled auto-merge (squash) October 17, 2024 16:49
@dokterbob dokterbob enabled auto-merge (squash) October 17, 2024 16:49
dokterbob
dokterbob approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contrib!

Please update the PR once #1445 is merged so tests can be evaluated.

@dokterbob dokterbob merged commit b78f335 into Chainlit:main Oct 17, 2024
3 of 15 checks passed
dokterbob pushed a commit that referenced this pull request Oct 21, 2024
@maoguy @dokterbob
Fix dialog boxes extending beyond the window (#1446)
b0232e1 
Closes #1422.

Co-authored-by: laodanfeng <[email protected]>
@maoguy
Copy link
Contributor Author

maoguy commented Oct 22, 2024

LGTM. Thanks for the contrib!

Please update the PR once #1445 is merged so tests can be evaluated.

How to complete and close this pull request？

dokterbob pushed a commit that referenced this pull request Oct 22, 2024
@maoguy @dokterbob
Fix dialog boxes extending beyond the window (#1446)
2162055 
Closes #1422.

Co-authored-by: laodanfeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokterbob dokterbob dokterbob approved these changes

Assignees
No one assigned
Labels
bug Something isn't working frontend Pertains to the frontend. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maoguy @dokterbob