fix: tasklist when chainlit is submounted #1408
Conversation
There was a problem hiding this comment.
I've validated the fix! 👍🏼
We get some free cleanup, see my other comment.
Would also be nice to remove changes from socket.py from this patch. Specifically, this allows us to backport it to 1.3.x without merge conflicts. Same for lock files, AFAIK they have nothing to do with this fix.
git checkout main -- backend/chainlit/socket.py is your friend. ;)
| @@ -70,7 +73,7 @@ const TaskList = ({ isMobile }: { isMobile: boolean }) => { | |||
| return parsedUrl.pathname + parsedUrl.search; | |||
There was a problem hiding this comment.
If you go this way, I think you can (and should) also try to remove the workaround here as well; before you'd get double base URL's (so you removed them).
Now, you are making a query for a relative URL. Might as well query the full URL and have a bit less code.
|
@willydouhard Any chance you could continue with the other cleanup requested (e.g. removing unrelated changes)? If not I can do it, but might not get to it until ~Monday. |
|
Closed in favour of cleaned version (containing only changes to actual task list): #1433 |
Fixing #1400.
The issue is that the tasklist url is already containing the subpath.
useApiwill add the subpath again. So we just useuseSWRraw here.