feat: beacon node process electra attestations EIP-7549 #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
reviewed
May 7, 2024
twoeths
reviewed
May 7, 2024
twoeths
reviewed
May 7, 2024
|
|
||
| const validatorIndices = this.getBeaconCommittees(data.slot, committeeIndices); | ||
|
|
||
| const attestingIndices = new Set(aggregationBits.intersectValues(validatorIndices)); |
There was a problem hiding this comment.
return the array from intersectValues directly, there should not be any duplicates here
if there is, it'll fail the validation anyway, the created Set does not help
twoeths
reviewed
May 7, 2024
| } else { | ||
| const {aggregationBits, committeeBits, data} = attestation as electra.Attestation; | ||
|
|
||
| // There is a naming conflict on the term `committeeIndices` |
There was a problem hiding this comment.
add TODO: resolve the naming conflicts...
twoeths
reviewed
May 7, 2024
| `aggregationBitsLength=${attestation.aggregationBits.bitLen} committeeLength=${committee.length}` | ||
| ); | ||
| if (fork >= ForkSeq.electra) { | ||
| if (data.index !== 0) { |
twoeths
reviewed
May 7, 2024
| .map((committeeIndex) => epochCtx.getBeaconCommittee(data.slot, committeeIndex).length) | ||
| .reduce((acc, committeeSize) => acc + committeeSize, 0); | ||
|
|
||
| if (attestationElectra.aggregationBits.bitLen !== participantCount) { |
twoeths
reviewed
May 7, 2024
| @@ -146,7 +147,7 @@ export async function importBlock( | |||
|
|
|||
| for (const attestation of attestations) { | |||
| try { | |||
| const indexedAttestation = postState.epochCtx.getIndexedAttestation(attestation); | |||
| const indexedAttestation = postState.epochCtx.getIndexedAttestation(fork, attestation); | |||
There was a problem hiding this comment.
add TODO: figure out how to reuse the attesting indices computed from state transition
twoeths
reviewed
May 7, 2024
| getIndexedAttestationSignatureSet(state, state.epochCtx.getIndexedAttestation(attestation)) | ||
| getIndexedAttestationSignatureSet( | ||
| state, | ||
| state.epochCtx.getIndexedAttestation(state.epochCtx.config.getForkSeq(signedBlock.message.slot), attestation) |
There was a problem hiding this comment.
add TODO: figure how to get attesting indices of an attestation once per block processing
|
@tuyennhv all your feedbacks have been addressed, and the changes are reflected in |
g11tech
pushed a commit
that referenced
this pull request
May 24, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
to g11tech/lodestar
that referenced
this pull request
Jun 19, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Process attestations in block * Fix check-types * Address comments
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Process attestations in block * Fix check-types * Address comments
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Process attestations in block * Fix check-types * Address comments
|
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBeaconCommittees()to retrieve multiple committees from a single attestationgetAttestingIndices()to retrieve a list of indices of validators who attested in the provided attestationPart of #6341 and #6689