fix: fix the devnet2 bug of invalid stateroot calc post consolidation

ChainSafe · Aug 9, 2024 · e88a1e3 · e88a1e3
1 parent 73b2112
commit e88a1e3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/state-transition/src/util/electra.ts b/packages/state-transition/src/util/electra.ts
@@ -68,7 +68,12 @@ export function switchToCompoundingValidator(state: CachedBeaconStateElectra, in
   const validator = state.validators.get(index);
 
   if (hasEth1WithdrawalCredential(validator.withdrawalCredentials)) {
-    validator.withdrawalCredentials[0] = COMPOUNDING_WITHDRAWAL_PREFIX;
+    // directly modifying the byte leads to ssz missing the modification resulting into
+    // wrong root compute, although slicing can be avoided but anyway this is not going
+    // to be a hot path so its better to clean slice and avoid side effects
+    const newWithdrawalCredentials = validator.withdrawalCredentials.slice();
+    newWithdrawalCredentials[0] = COMPOUNDING_WITHDRAWAL_PREFIX;
+    validator.withdrawalCredentials = newWithdrawalCredentials;
     queueExcessActiveBalance(state, index);
   }
 }