Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOCKS-344 Rewrite Parser in TypeScript #439

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

bprattes
Copy link
Contributor

@bprattes bprattes commented Jul 22, 2023

https://jira.catrob.at/browse/BLOCKS-344
The old code.xml parser was rewritten in Typescript to achieve better readability.

Your checklist for this pull request

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Make sure you use BLOCKS instead of CATROID in your commit message
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed (Actions)
  • Post a message in the #catblocks Slack channel and ask for a code reviewer

Copy link
Member

@MichaelFlucher MichaelFlucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Hiebl Hiebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Hiebl Hiebl merged commit 84d3b7e into Catrobat:develop Aug 6, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants