Interpolate DA from CD in Canada #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 11, 2018
tasks/ca/statcan/data.py
Outdated
| if colname != 'geo_code': | ||
| in_colnames.append('({colname} * (ST_Area(da.the_geom)/ST_Area(cd.the_geom))) {colname}'.format(colname=colname)) | ||
|
|
||
| insert_query = ''' |
tasks/ca/statcan/data.py
Outdated
| in_colnames = ['da.geom_id'] | ||
| for colname in out_colnames: | ||
| if colname != 'geo_code': | ||
| in_colnames.append('({colname} * (ST_Area(da.the_geom)/ST_Area(cd.the_geom))) {colname}'.format(colname=colname)) |
There was a problem hiding this comment.
line too long (129 > 120 characters)
tasks/ca/statcan/data.py
Outdated
| @@ -1,5 +1,6 @@ | |||
| import os | |||
| import urllib.request | |||
| import time | |||
added 2 commits
July 11, 2018 16:00
houndci-bot
reviewed
Jul 11, 2018
| if colname != 'geo_code': | ||
| # We reduce the number of decimals to reduce the size of the row to avoid hit | ||
| # the limit which is 8Kb. More info https://github.com/CartoDB/bigmetadata/issues/527 | ||
| in_colnames.append('round(cast(float8 ({colname} * (ST_Area(da.the_geom)/ST_Area(cd.the_geom))) as numeric), 2) {colname}'.format(colname=colname)) |
There was a problem hiding this comment.
line too long (163 > 120 characters)
houndci-bot
reviewed
Jul 11, 2018
| if colname != 'geo_code': | ||
| # We reduce the number of decimals to reduce the size of the row to avoid hit | ||
| # the limit which is 8Kb. More info https://github.com/CartoDB/bigmetadata/issues/527 | ||
| in_colnames.append('round(cast(float8 ({colname} * (ST_Area(da.the_geom)/ST_Area(cd.the_geom))) as numeric), 2) {colname}'.format(colname=colname)) |
There was a problem hiding this comment.
line too long (163 > 120 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking into account the unsolved bug in #527this works for the99%100% of the tables