Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use to-jyutping Package, Strict Typing, Migrate to Manifest Version 3 #8

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Use to-jyutping Package, Strict Typing, Migrate to Manifest Version 3 #8

merged 2 commits into from
Jul 25, 2024

Conversation

graphemecluster
Copy link
Member

No description provided.

@graphemecluster graphemecluster linked an issue Jul 21, 2024 that may be closed by this pull request
「匿」嘅音可能註錯咗喇 #6
Closed
@graphemecluster graphemecluster mentioned this pull request Jul 21, 2024
Open
laubonghaudoi
laubonghaudoi approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@laubonghaudoi laubonghaudoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

呢個PR有啲大我都睇唔晒所以照approve嘞，不過有個問題係我點發佈落 Chrome store？係咪你之後會出個新嘅release噉我就可以將個zip攞去發佈？

仲有樣嘢係，如果可以加個unittest就最好嘞，防止以後爆。

@graphemecluster
Copy link
Member Author

@laubonghaudoi 係呀，不過之前上架有啲係以綾香名義出嘅，你可能要問佢攞權限
個 PR 咁大係因為有啲其實係兩年前寫落嘅
Unit test 我之後先加，merge 咗先？

@laubonghaudoi laubonghaudoi merged commit dc9e3b6 into main Jul 25, 2024
1 check passed
@laubonghaudoi
Copy link
Member

冇問題，已經merge

@graphemecluster graphemecluster mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laubonghaudoi laubonghaudoi laubonghaudoi approved these changes

@ayaka14732 ayaka14732 Awaiting requested review from ayaka14732

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

「匿」嘅音可能註錯咗喇
2 participants
@graphemecluster @laubonghaudoi