Refactored and tested cpdFmax2pCp2.m #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tztsai
reviewed
Aug 22, 2024
| if Fmax < FmaxCritical(1) | ||
| p = extrapolateLowFmax(Fmax, n, FmaxCritical(1)); | ||
| elseif Fmax > FmaxCritical(end) | ||
| p = extrapolateHighFmax(Fmax, n, FmaxCritical(end)); |
There was a problem hiding this comment.
In the original code, FmaxCritical(3) is used instead of FmaxCritical(end). Are they the same?
|
We will come back to this once we reach this point in the dependency graph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored cpdFmax2pCp2.m using LLM.
Added unit tests for function and its new sub functions.
All tests working correctly