Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pacman] Add commented ILoveCandy #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

TheWyn
Copy link
Contributor

@TheWyn TheWyn commented Oct 16, 2024

PrettyProgressBar patch includes an option for ILoveCandy and isn't included in the config. All the other options are already added here.

PrettyProgressBar patch includes an option for ILoveCandy and isn't included in the config.  All the other options are already added here.
@1Naim
Copy link
Member

1Naim commented Oct 16, 2024

ILoveCandy is part of core pacman but yeah we can add this to the makepkg.conf

@ptr1337
Copy link
Member

ptr1337 commented Oct 16, 2024

Why do we want this? This is actually already set in the install pacman config:
https://github.com/CachyOS/CachyOS-Live-ISO/blob/master/archiso/airootfs/etc/pacman-more.conf#L35

@1Naim
Copy link
Member

1Naim commented Oct 16, 2024

My thinking was mainly for posterity in the pacman.conf provided by the package itself, considering all the other options have the comments too.

@TheWyn
Copy link
Contributor Author

TheWyn commented Oct 16, 2024

It is not included in the .pacnew whenever pacman has an update

@ptr1337
Copy link
Member

ptr1337 commented Oct 16, 2024

Thats an argument

@1Naim 1Naim self-requested a review October 20, 2024 18:00
Copy link
Member

@1Naim 1Naim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flew under my radar, but please update the checksums too. You can do this with updpkgsums and makepkg --printsrcinfo > .SRCINFO to update .SRCINFO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants