Setup eslint for polyfills package.

packages/@jscorlib-repo/linters/src/environment.js

@@ -0,0 +1,6 @@
+import * as path from "node:path";
+import * as url from "node:url";
+
+// Make ESLint running in VSCode happy.
+// VSCode is on Node 20 right now. import.meta.dirname is not available yet.
+export const repoRootDir = path.resolve(url.fileURLToPath(import.meta.url), "../../../../..");

packages/@jscorlib-repo/linters/src/eslint-rules/base.js

@@ -0,0 +1,82 @@
+// @ts-check
+import eslint from "@eslint/js";
+import stylistic from "@stylistic/eslint-plugin";
+import jsdoc from "eslint-plugin-jsdoc";
+import tseslint from "typescript-eslint";
+import { repoRootDir } from "../environment.js";
+
+export const baseConfig = tseslint.config(
+ eslint.configs.recommended,
+ ...tseslint.configs.recommendedTypeChecked,
+ ...tseslint.configs.stylisticTypeChecked,
+ {
+ languageOptions: {
+ parserOptions: {
+ project: true,
+ tsconfigRootDir: repoRootDir,
+ },
+ },
+ rules: {
+ "@typescript-eslint/array-type": ["error", {
+ default: "array-simple",
+ readonly: "array-simple",
+ }],
+ "@typescript-eslint/no-unused-vars": [
+ "error",
+ {
+ "args": "all",
+ "argsIgnorePattern": "^_",
+ "caughtErrors": "all",
+ "caughtErrorsIgnorePattern": "^_",
+ "destructuredArrayIgnorePattern": "^_",
+ // https://github.com/tc39/proposal-discard-binding
+ "varsIgnorePattern": "^_void",
+ "ignoreRestSiblings": true,
+ },
+ ],
+ "@typescript-eslint/explicit-member-accessibility": "error",
+ "@typescript-eslint/prefer-nullish-coalescing": [
+ "error", {
+ ignorePrimitives: {
+ string: true,
+ },
+ },
+ ],
+ "@typescript-eslint/no-inferrable-types": [
+ "error", {
+ ignoreParameters: true,
+ ignoreProperties: true,
+ },
+ ],
+ // This rule does not handle `unknown` well
+ "@typescript-eslint/restrict-template-expressions": "warn",
+ "@typescript-eslint/unbound-method": ["error", { ignoreStatic: true }],
+ },
+ },
+ {
+ plugins: {
+ "@stylistic": stylistic,
+ },
+ rules: {
+ "@stylistic/indent": ["error", 2],
+ "@stylistic/quotes": ["error", "double", {
+ "avoidEscape": true,
+ "allowTemplateLiterals": true,
+ }],
+ "@stylistic/semi": "error",
+ "@stylistic/comma-dangle": ["error", "always-multiline"],
+ "@stylistic/eol-last": ["error", "always"],
+ },
+ },
+ {
+ plugins: {
+ jsdoc,
+ },
+ rules: {
+ "jsdoc/no-undefined-types": ["warn", {
+ markVariablesAsUsed: true,
+ disableReporting: true,
+ }],
+ },
+ },
+);

packages/@jscorlib-repo/linters/src/eslint-rules/index.js

@@ -0,0 +1 @@
+export * from "./base.js";

packages/@jscorlib-repo/linters/src/index.d.ts

@@ -1,2 +1,9 @@
+import tseslint from "typescript-eslint";
+
 /** Absolute path of repository root folder. */
 export const repoRootDir: string;
+
+export namespace ESLintRules {
+ // See https://github.com/typescript-eslint/typescript-eslint/issues/8571
+ export const baseConfig: ReturnType<typeof tseslint.config>;
+}

packages/@jscorlib-repo/linters/src/index.js

@@ -1,5 +1,2 @@
-import * as path from "node:path";
-import * as url from "node:url";
-
-// VSCode is on Node 20 right now. import.meta.dirname is not available.
-export const repoRootDir = path.resolve(url.fileURLToPath(import.meta.url), "../../../../..");
+export * from "./environment.js";
+export * as ESLintRules from "./eslint-rules/index.js";

packages/@jscorlib/polyfills/eslint.config.js

@@ -0,0 +1,7 @@
+// @ts-check
+import * as JscorlibLinters from "@jscorlib-repo/linters";
+import tseslint from "typescript-eslint";
+
+export default tseslint.config(
+ ...JscorlibLinters.ESLintRules.baseConfig,
+);

packages/@jscorlib/polyfills/src/explicit-resource-management/disposableStack.ts

@@ -43,14 +43,16 @@ export class DisposableStack implements globalThis.DisposableStack {
  [Symbol.dispose]: () => {
  onDispose();
  },
- })
+ });
  }
  public move(): DisposableStack {
  const inst = new DisposableStack();
  inst._stack = this._stack;
  this._stack = undefined;
  return inst;
  }
- public [Symbol.dispose] = this.dispose;
- public readonly [Symbol.toStringTag] = "jscorlib::DisposableStack"
+ public [Symbol.dispose](): void {
+ this.dispose();
+ }
+ public readonly [Symbol.toStringTag] = "jscorlib::DisposableStack";
 }

packages/@jscorlib/polyfills/src/explicit-resource-management/index.ts

@@ -7,5 +7,5 @@
  * 
  * @module
  */
-export * from "./disposableStack"
-export * from "./installer"
+export * from "./disposableStack";
+export * from "./installer";

packages/@jscorlib/polyfills/src/promises/installer.ts

@@ -3,5 +3,6 @@ import { withResolvers } from "./withResolvers";
 
 export function installPolyfill(options: InstallPolyfillOptions): void {
  const { globalThis: global = globalThis } = options;
+ // eslint-disable-next-line @typescript-eslint/unbound-method
  global.Promise.withResolvers ??= withResolvers;
 }

packages/@jscorlib/polyfills/src/promises/withResolvers.ts

@@ -2,11 +2,11 @@
  * Polyfill of {@link Promise.withResolvers}.
  * @see [ES2023: ES Promise.withResolvers](https://github.com/tc39/proposal-promise-with-resolvers)
  */
-export function withResolvers<T>(): PromiseWithResolvers<T> {
+export function withResolvers<T>(this: void): PromiseWithResolvers<T> {
  const result = {} as PromiseWithResolvers<T>;
  result.promise = new Promise((res, rej) => {
  result.resolve = res;
  result.reject = rej;
- })
+ });
  return result;
 }

packages/jscorlib/eslint.config.js

@@ -1,81 +1,7 @@
 // @ts-check
-import eslint from "@eslint/js";
 import * as JscorlibLinters from "@jscorlib-repo/linters";
-import stylistic from "@stylistic/eslint-plugin";
-import jsdoc from "eslint-plugin-jsdoc";
 import tseslint from "typescript-eslint";
 
 export default tseslint.config(
- eslint.configs.recommended,
- ...tseslint.configs.recommendedTypeChecked,
- ...tseslint.configs.stylisticTypeChecked,
- {
- languageOptions: {
- parserOptions: {
- project: true,
- tsconfigRootDir: JscorlibLinters.repoRootDir,
- },
- },
- rules: {
- "@typescript-eslint/array-type": ["error", {
- default: "array-simple",
- readonly: "array-simple",
- }],
- "@typescript-eslint/no-unused-vars": [
- "error",
- {
- "args": "all",
- "argsIgnorePattern": "^_",
- "caughtErrors": "all",
- "caughtErrorsIgnorePattern": "^_",
- "destructuredArrayIgnorePattern": "^_",
- // https://github.com/tc39/proposal-discard-binding
- "varsIgnorePattern": "^_void",
- "ignoreRestSiblings": true,
- },
- ],
- "@typescript-eslint/explicit-member-accessibility": "error",
- "@typescript-eslint/prefer-nullish-coalescing": [
- "error", {
- ignorePrimitives: {
- string: true,
- },
- },
- ],
- "@typescript-eslint/no-inferrable-types": [
- "error", {
- ignoreParameters: true,
- ignoreProperties: true,
- },
- ],
- // This rule does not handle `unknown` well
- "@typescript-eslint/restrict-template-expressions": "warn",
- },
- },
- {
- plugins: {
- "@stylistic": stylistic,
- },
- rules: {
- "@stylistic/indent": ["error", 2],
- "@stylistic/quotes": ["error", "double", {
- "avoidEscape": true,
- "allowTemplateLiterals": true,
- }],
- "@stylistic/semi": "error",
- "@stylistic/comma-dangle": ["error", "always-multiline"],
- "@stylistic/eol-last": ["error", "always"],
- },
- },
- {
- plugins: {
- jsdoc,
- },
- rules: {
- "jsdoc/no-undefined-types": ["warn", {
- markVariablesAsUsed: true,
- disableReporting: true,
- }],
- },
- },
+ ...JscorlibLinters.ESLintRules.baseConfig,
 );