Drop vaddr_t from and apply style(9) fixes to minimal caprevoke code #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksdavis
approved these changes
Jul 24, 2023
bsdjhb
approved these changes
Jul 25, 2023
In particular, the mask calculations were overly-complicated. Rewriting them slightly differently allows special cases to be removed and common code to be shared.
These should be entirely the same for all supported architectures, so make the former more obviously an alias for the latter.
brooksdavis
approved these changes
Jul 25, 2023
bsdjhb
approved these changes
Jul 26, 2023
| @@ -62,12 +62,29 @@ static uint64_t caprev_shadow_nomap_last_word_mask(ptraddr_t base, size_t len); | |||
| * the fine-grained bitmap where the first word would be located. | |||
| */ | |||
|
|
|||
| static size_t | |||
| caprev_shadow_nomap_granule(ptraddr_t addr) | |||
There was a problem hiding this comment.
Thanks, this is a nice cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.