OutlineCfg rewrite returns new BB and CFG nodes #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
commented
Sep 22, 2023
| .unwrap(); | ||
| h.validate(&PRELUDE_REGISTRY).unwrap(); | ||
| let new_entry = h.children(h.root()).next().unwrap(); | ||
| assert_eq!(new_block, h.children(h.root()).next().unwrap()); |
There was a problem hiding this comment.
new_entry, although correct, could also suggest the entry node inside the new sub-cfg, hence "renaming" to new_block
cqc-alec
approved these changes
Sep 25, 2023
acl-cqc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a good use of the facility for a rewrite to return a rewrite-specific result, and preliminary to other upcoming PRs (specifically #247)
The new CFG node is non-trivial to find given its parent (basic block) as that has several children: not only Input and Output but also constant nodes to build the predicate.