Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Update inference test to not use DFG builder #550

Merged
merged 1 commit into from
Sep 22, 2023
Merged

tests: Update inference test to not use DFG builder #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/extension/infer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,8 +671,7 @@ mod test {

use super::*;
use crate::builder::test::closed_dfg_root_hugr;
use crate::builder::{BuildError, DFGBuilder, Dataflow, DataflowHugr};
use crate::extension::{ExtensionSet, EMPTY_REG, PRELUDE_REGISTRY};
use crate::extension::{ExtensionSet, PRELUDE_REGISTRY};
use crate::hugr::{validate::ValidationError, Hugr, HugrMut, HugrView, NodeType};
use crate::macros::const_extension_ids;
use crate::ops::{self, dataflow::IOTrait, handle::NodeHandle, OpTrait};
Expand Down Expand Up @@ -813,19 +812,33 @@ mod test {
// This generates a solution that causes validation to fail
// because of a missing lift node
fn missing_lift_node() -> Result<(), Box<dyn Error>> {
let builder = DFGBuilder::new(
FunctionType::new(type_row![NAT], type_row![NAT])
.with_extension_delta(&ExtensionSet::singleton(&"R".try_into().unwrap())),
let mut hugr = Hugr::new(NodeType::pure(ops::DFG {
signature: FunctionType::new(type_row![NAT], type_row![NAT])
.with_extension_delta(&ExtensionSet::singleton(&A)),
}));

let input = hugr.add_node_with_parent(
hugr.root(),
NodeType::pure(ops::Input {
types: type_row![NAT],
}),
)?;
let [w] = builder.input_wires_arr();
let hugr = builder.finish_hugr_with_outputs([w], &EMPTY_REG);

let output = hugr.add_node_with_parent(
hugr.root(),
NodeType::pure(ops::Output {
types: type_row![NAT],
}),
)?;

hugr.connect(input, 0, output, 0)?;

// Fail to catch the actual error because it's a difference between I/O
// nodes and their parents and `report_mismatch` isn't yet smart enough
// to handle that.
assert_matches!(
hugr,
Err(BuildError::InvalidHUGR(ValidationError::CantInfer(_)))
hugr.infer_and_validate(&PRELUDE_REGISTRY),
Err(ValidationError::CantInfer(_))
);
Ok(())
}
Expand Down