-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New/validate types #467
Merged
Merged
New/validate types #467
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7f8a2f1
Prelim: HugrMut test: change NAT from COPYABLE_T to USIZE_T
acl-cqc 168376b
First remove (EQ,ANY)_(CUS,)T in favour of prelude USIZE_T and QB_T
acl-cqc 8d743fa
Prelim: change builder::test::BIT to BOOL_T not USIZE_T
acl-cqc 6de64c8
Add ExtensionRegistry, pass into validate() and finish_hugr()
acl-cqc 36a7192
Convert to BTreeMap -> const EMPTY_REG
acl-cqc c7c62cd
ExtensionRegistry::get, new SignatureErrors, ValidationError::Signatu…
acl-cqc 09b7536
Add Type::iter_prims (pub PrimType; TypeRow::iter() double-ended)
acl-cqc ca34de3
Add validate_{custom_type,type,type_arg}; compiles, tests failing
acl-cqc 4c2e3db
Revert iter_prims/pub-PrimType; move validation methods into (Custom)…
acl-cqc ea70884
Add prelude_registry, test_registry; use in tests ==> fix
acl-cqc f797080
Check CustomType has correct bound
acl-cqc bea1d94
clippy
acl-cqc c2b3b7c
Merge 'origin/main' into new/validate_types, update SumType
acl-cqc 624cc0e
WrongBound message
acl-cqc 3f793f6
Replace COPYABLE_T with FLOAT64_TYPE
acl-cqc 85fec39
finish_prelude_hugr
acl-cqc eae032f
finish_prelude_hugr_with_outputs (for DFG builder only)
acl-cqc cad92b0
Into-ExtensionRegistry: include name if duplicate
acl-cqc a043e90
Add tests: unregistered_extension, invalid_types
acl-cqc 704e84b
Merge remote-tracking branch 'origin/main' into new/validate_types
acl-cqc 4a90e74
Merge remote-tracking branch 'origin/main' into new/validate_types
acl-cqc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
method names are getting unwieldy, one for another time