feat: Extension validation can take a closure of solutions #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
reviewed
Aug 25, 2023
| @@ -40,18 +40,30 @@ struct ValidationContext<'a> { | |||
| impl Hugr { | |||
| /// Check the validity of the HUGR. | |||
| pub fn validate(&self) -> Result<(), ValidationError> { | |||
| let mut validator = ValidationContext::new(self); | |||
| self.validate_with_extension_closure(HashMap::new()) | |||
There was a problem hiding this comment.
please add a todo for validating hugrs with input extension set variables
There was a problem hiding this comment.
I've added issue #457 after our discussion this morning
There was a problem hiding this comment.
cool, the comment here can link to that then
ss2165
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #454.
Return from extension inference an extra solution set, which instantiates all of the inference variables to the empty set, meaning metavariables which depend on them can be solved