Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix the logic of get_io #442

Merged
merged 3 commits into from
Aug 22, 2023
Merged

[fix] Fix the logic of get_io #442

merged 3 commits into from
Aug 22, 2023

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented Aug 22, 2023 •
edited
Loading

Fix the logic of get_io and update the wording of the is_superset function.
Due to this bug, some tests weren't having their extension requirements validated, so update those too

@croyzor croyzor mentioned this pull request Aug 22, 2023
Merged
@croyzor croyzor requested a review from ss2165 August 22, 2023 15:57
@croyzor croyzor marked this pull request as ready for review August 22, 2023 15:57
@croyzor croyzor enabled auto-merge August 22, 2023 15:58
@croyzor croyzor added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit e1bbb08 Aug 22, 2023
6 checks passed
@croyzor croyzor deleted the fix/get_io branch August 22, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ss2165 ss2165 ss2165 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@croyzor @ss2165