Change compute_signature to return FunctionType (et al) #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
commented
Aug 22, 2023
| @@ -227,7 +227,7 @@ impl OpDef { | |||
| // TODO bring this assert back once resource inference is done? | |||
| // https://github.com/CQCL-DEV/hugr/issues/425 | |||
| // assert!(res.contains(self.extension())); | |||
| Ok(FunctionType::new(ins, outs).with_extension_delta(&res)) | |||
| Ok(res) | |||
There was a problem hiding this comment.
I've left this as this slightly-long-way around because of the preceding comment, which I've not tried to address in this PR. (Perhaps I could, but it's orthogonal, and looks like it might be opening another can of worms - it relates to #389 so I've noted it on there.)
ss2165
reviewed
Aug 22, 2023
Heh, I came to the same (or nearly) conclusion independently, and have switched to There does still appear to be some confusion/disagreement in the code as to whether the ExtensionSet should include the owning Resource, but let's leave that for #389 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....as this is now equal to the current tuple (TypeRow,TypeRow,Extensions). A longstanding TODO.
Note this does not address the confusion/disagreement across the codebase as to whether the ExtensionSet should include the resource declaring the op.