Enable static simple predicates #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Aug 17, 2023
| @@ -46,7 +46,7 @@ impl Const { | |||
| } | |||
|
|
|||
| /// Constant Sum over units, used as predicates. | |||
| pub fn simple_predicate(tag: usize, size: usize) -> Self { | |||
| pub fn simple_predicate(tag: usize, size: u8) -> Self { | |||
| /// of a "simple predicate" (sum over empty tuples), store only the size of the predicate. | ||
| enum SumType { | ||
| #[display(fmt = "SimplePredicate({})", "_0")] | ||
| Simple(u8), |
There was a problem hiding this comment.
The thinking being that simple predicates branching factor >255 is not worth optimising for, and u8 will allow memory and serialisation optimisations.
cqc-alec
approved these changes
Aug 17, 2023
ss2165
force-pushed
the
new/predicate-opt
branch
from
3bf82dd
to
f7525ee
Compare
ss2165
force-pushed
the
new/predicate-opt
branch
from
f7525ee
to
ceb6557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these are very commonly used types, optimise them a bit by adding a dedicated internal representation.
Fortunately the check for constructing them is easy.
Closes #397