Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Resource to Extension #415

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Rename Resource to Extension #415

merged 7 commits into from
Aug 18, 2023

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Aug 16, 2023

Closes #371

@ss2165 ss2165 requested a review from croyzor August 16, 2023 15:45
@croyzor
Copy link
Contributor

croyzor commented Aug 18, 2023

A couple of things:

  • In extensions, the self-reference constant is still called RESOURCE_ID, which seems wrong
  • When we talk about signatures in terms of extensions, the goto extension variable name is R (which I'm less bothered about)

@ss2165
Copy link
Member Author

ss2165 commented Aug 18, 2023

Great catch - fixed RESOURCE_ID
I am also happy to leave R as a symbol

@ss2165 ss2165 added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 2d55662 Aug 18, 2023
6 checks passed
@ss2165 ss2165 deleted the refactor/resource2extension branch August 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@croyzor croyzor croyzor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "Resource" -> "Extension" in spec and implementation
2 participants
@ss2165 @croyzor