Add static values to resources #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`KnownTypeConst` trait for simple checks
for comparisons of constants that implement PartialEq
ss2165
commented
Aug 16, 2023
| @@ -126,6 +128,32 @@ trait TypeParametrised { | |||
| } | |||
| } | |||
|
|
|||
| /// A constant value provided by a resource. | |||
| /// Must be an instance of a type available to the resource. | |||
There was a problem hiding this comment.
maybe this should be enforced as a check on creation?
There was a problem hiding this comment.
never mind - requires the resource dependency system first
aborgna-q
approved these changes
Aug 16, 2023
src/values.rs
Outdated
|
|
||
| /// Fixed implementation of [CustomConst::check_custom_type] that checks | ||
| /// against known correct type. | ||
| fn check_custom_type(&self, typ: &CustomType) -> Result<(), CustomCheckFailure> { |
There was a problem hiding this comment.
I'm wary of the same-name methods here,
-
On one side it opens up the possibility of buggy impls having different behaviour for
<T as CustomConst>::check_custom_typeand<T as KnownTypeConst>::check_custom_type. -
Even with the same code, the compiler will ask you to disambiguate between the two at every callsite.
Perhaps it could be called check_known_type here, and still use it for the impl of CustomConst for ConstUsize ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KnownConstTypeConstUsizeto prelude