[doc] Tidy hugr specification #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
reviewed
Aug 16, 2023
doug-q
force-pushed
the
feature/tidy-hugr-spec
branch
from
c6abd39
to
80695eb
Compare
|
I've rebased, please have another look. |
ss2165
reviewed
Aug 29, 2023
specification/hugr.md
Outdated
Comment on lines
1082
to
1083
| I’m going to define them in terms of resources. We have the “builtin” | ||
| resource which should always be available when writing hugr plugins. |
There was a problem hiding this comment.
is this now the only mention of resources? does it need defining elsewhere?
There was a problem hiding this comment.
Indeed, I've changed this to "We will define them in terms of extensions"
Among others, uniformly refer to graph edges as edges rather than wires.
doug-q
force-pushed
the
feature/tidy-hugr-spec
branch
from
80695eb
to
ce8451b
Compare
ss2165
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among others, uniformly refer to graph edges as edges rather than wires.
Note that SimpleType and ClassicalType have been mostly removed from the spec, my mentions here should be checked.