Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from static type bounds to dynamic #399

Merged
merged 10 commits into from
Aug 11, 2023
Merged

Move from static type bounds to dynamic #399

merged 10 commits into from
Aug 11, 2023

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Aug 11, 2023

also move some non-core types to a prelude resourece
rename TypeTag -> TypeBound

@ss2165 ss2165 requested a review from aborgna-q August 11, 2023 14:45
aborgna-q
aborgna-q approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite noisy diff, but LGTM

src/resource.rs Outdated Show resolved Hide resolved
src/types/type_enum.rs Show resolved Hide resolved
@ss2165 @aborgna-q
fix typo
207da5e 
Co-authored-by: Agustín Borgna <[email protected]>
@ss2165 ss2165 merged commit adaf23d into refactor/types-redux Aug 11, 2023
@ss2165 ss2165 deleted the redux/radical branch August 11, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborgna-q aborgna-q aborgna-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ss2165 @aborgna-q