Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put LeafOp::CustomOp inside a box. #394

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

aborgna-q
Copy link
Collaborator

Low-hanging fruit to reduce the OpType footprint.

Reduces LeafOp footprint from 216b to 88b, and OpType from 216b to 152b

This reduces LeafOp footprint from 216b to 88b,
and OpType from 216b to 152b
@aborgna-q aborgna-q requested a review from ss2165 August 10, 2023 14:59
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some weird diffs but seems good 👍

@aborgna-q aborgna-q added this pull request to the merge queue Aug 10, 2023
@aborgna-q
Copy link
Collaborator Author

aborgna-q commented Aug 10, 2023

rustfmt 🦋 🌪️

Merged via the queue into main with commit d65d94f Aug 10, 2023
5 checks passed
@aborgna-q aborgna-q deleted the perf/optimize-leaf-layout branch August 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants