[bugfix] Check #TypeArgs == #TypeParams for TypeDefs as well as OpDefs #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
commented
Aug 3, 2023
src/resource.rs
Outdated
| def.instantiate_concrete([TypeArg::HashableType(HashableType::String)]) | ||
| .unwrap_err(); | ||
| // Too few arguments: | ||
| def.instantiate_concrete([]).unwrap_err(); |
There was a problem hiding this comment.
This one was previously panicking with an index-out-of-bounds in computing the tag
There was a problem hiding this comment.
(If I'd provided a TypeDefTag::Explicit it would have just returned a CustomType)
ss2165
reviewed
Aug 3, 2023
src/resource.rs
Outdated
Comment on lines
724
to
733
| def.instantiate_concrete([TypeArg::HashableType(HashableType::String)]) | ||
| .unwrap_err(); | ||
| // Too few arguments: | ||
| def.instantiate_concrete([]).unwrap_err(); | ||
| // Too many arguments: | ||
| def.instantiate_concrete([ | ||
| TypeArg::ClassicType(ClassicType::F64), | ||
| TypeArg::ClassicType(ClassicType::F64), | ||
| ]) | ||
| .unwrap_err(); |
There was a problem hiding this comment.
can we assert_matches on some known errors?
There was a problem hiding this comment.
We can. They'll change in an upcoming PR but yeah, ok
There was a problem hiding this comment.
ah, in which case some TODOs should be enough
There was a problem hiding this comment.
They'll be simple updates, and it'll make the change obvious and explicit, so done.
acl-cqc
force-pushed
the
bugfix/typedef_num_args
branch
from
bbcef7c
to
cc0b47b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was in there, but seemingly in the wrong place. Not sure if my comment on
TypeArgError::WrongNumberhad mislead so I've corrected that ;)