A few more Eq fixes #340
Merged
A few more Eq fixes #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
commented
Aug 3, 2023
| @@ -444,5 +450,7 @@ mod test { | |||
| let t: SimpleType = typ_float.clone().into(); | |||
| assert_matches!(val.check_type(&t.try_into().unwrap()), | |||
| Err(ConstTypeError::CustomCheckFail(CustomCheckFail::TypeMismatch(a, b))) => a == typ_int && b == typ_float); | |||
|
|
|||
| assert_eq!(val, val); | |||
There was a problem hiding this comment.
Yes, this was failing before, because equality of Box<dyn CustomConst> does not fall back to PartialEq....
ss2165
approved these changes
Aug 3, 2023
src/values.rs
Outdated
| @@ -16,7 +16,7 @@ use crate::{ | |||
|
|
|||
| /// A constant value/instance of a [HashableType]. Note there is no | |||
| /// equivalent of [HashableType::Variable]; we can't have instances of that. | |||
| #[derive(Clone, Debug, PartialEq, serde::Serialize, serde::Deserialize)] | |||
| #[derive(Clone, Debug, PartialEq, Eq, serde::Serialize, serde::Deserialize)] | |||
src/values.rs
Outdated
| @@ -108,6 +108,8 @@ pub enum ContainerValue<T> { | |||
| Sum(usize, Box<T>), // Tag and value | |||
| } | |||
|
|
|||
| impl<Elem: Eq> Eq for ContainerValue<Elem> {} | |||
There was a problem hiding this comment.
In fact we can just #[derive(Eq)] - the derive macro is smart enough to condition the generated impl on the appropriate condition of the arguments, which is pretty neat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equal_const