CustomType's are Simple not necessarily Classic, and report their TypeTag #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acl-cqc
commented
Aug 1, 2023
•
acl-cqc
commented
- Hopefully this will fix problems you were seeing @ss2165
acl-cqc
changed the title
acl-cqc
commented
Aug 1, 2023
| impl From<CustomType> for ClassicType { | ||
| fn from(ty: CustomType) -> Self { | ||
| ty.classic_type() | ||
| /// This parallels [SimpleType::new_tuple] and [SimpleType::new_sum] |
There was a problem hiding this comment.
I don't see any point in having an equivalent to ClassicType::new_tuple. We can statically rule out ClassicType::new_tuple(...Qubit...) whereas here we cannot, so at best we can only impl TryFrom<CustomType> for ClassicType and you might as well turn the ÇustomType into a SimpleType and try_from that.
…eTag CustomType's convert into *correct* SimpleType via Into (like new_tuple) Drop .classic_type(), add .tag()
acl-cqc
force-pushed
the
bugfix/custom_simple
branch
from
fb41571
to
3b8f8f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.