Notify slack with overall result of coverage check. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
approved these changes
Aug 1, 2023
.github/workflows/coverage.yml
Outdated
Comment on lines
52
to
54
| echo "msg=Coverage check for hugr shows no regression. :-) ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "msg=Coverage check for hugr shows regression. :-( ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Add an emoji to quickly differentiate the cases on slack?
(:white_check_mark: vs :x:?)
There was a problem hiding this comment.
Just running a test to make sure this works...
| @@ -16,15 +18,50 @@ jobs: | |||
| uses: KyleMayes/install-llvm-action@v1 | |||
| with: | |||
| version: "16.0" # should match version used by rustc | |||
| - name: Generate coverage report | |||
| - name: Download previous summary | |||
There was a problem hiding this comment.
What happens if the artifact doesn't exist yet?
There was a problem hiding this comment.
This retrieves the last successful run with this workflow file, which must exist (unless we change the name of the workflow file or the artifact). (I did have to bootstrap it though: https://github.com/CQCL-DEV/hugr/actions/runs/5723914732 .)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.