Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require type checking on CustomConst #325

Merged
merged 3 commits into from
Aug 2, 2023
Merged

require type checking on CustomConst #325

merged 3 commits into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. require type checking on CustomConst 

    this now makes it impossible for use of static values of types from resources
that do not provide binary `CustomConst`.

Is this what we want?
    @ss2165
    ss2165 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    102fef1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. address review comments 

    string custom type check error
    @ss2165
    ss2165 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c4f3187 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into custom-const-check

    @ss2165
    ss2165 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    223f234 View commit details
    Browse the repository at this point in the history