Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataflowParent OpTag #323

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Add DataflowParent OpTag #323

merged 5 commits into from
Aug 3, 2023

Conversation

lmondada
Copy link
Contributor

I propose adding an OpTag to gather all OpType whose children form a dataflow sibling graph. I've called this an IOBlock to refer to the property that they are guaranteed to have an Input and Output child.

Other possible names could be DataflowWrapper, DataflowParent, DataBlock... Opinions?

@cqc-alec
Copy link
Collaborator

cqc-alec commented Aug 1, 2023

Good idea. Not too keen on the name IOBlock, since it only really makes sense with detailed knowledge of the spec (one might assume that a CFG is also an I/O block). Maybe DataflowParent or simply Dataflow?

@lmondada lmondada requested a review from cqc-alec August 3, 2023 09:02
@lmondada
Copy link
Contributor Author

lmondada commented Aug 3, 2023

I'm not sure what the definition of DataflowChild should be exactly. Right now OpTag::Dfg and OpTag::TailLoop are both DataflowChild and DataflowParent.

@lmondada lmondada changed the title Add IOBlock OpTag Add DataflowParent OpTag Aug 3, 2023
@cqc-alec cqc-alec added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit eb85eea Aug 3, 2023
5 checks passed
@cqc-alec cqc-alec deleted the feature/io-block branch August 3, 2023 10:25
@lmondada lmondada mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants