Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Spec formatting #312

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[fix] Spec formatting #312

merged 2 commits into from
Jul 28, 2023

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented Jul 28, 2023

I'm assuming this wasn't done on purpose?

@croyzor croyzor requested a review from ss2165 July 28, 2023 11:20
@ss2165
Copy link
Member

ss2165 commented Jul 28, 2023

Looking at the blame, I think it was done on purpose in #252 because we stopped referring to linear types explicitly, and the rest is covered in the quantum resource

@croyzor
Copy link
Contributor Author

croyzor commented Jul 28, 2023

Regardless, I think it looks terrible:

image

Messes up our ToC:

image

and don't think it's worth keeping this way

@ss2165
Copy link
Member

ss2165 commented Jul 28, 2023

ah right yes they're not valid markdown comments! Just remove the lines

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines can be removed

@croyzor croyzor requested a review from ss2165 July 28, 2023 11:51
@croyzor croyzor enabled auto-merge July 28, 2023 11:52
@croyzor croyzor added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit dc6da1a Jul 28, 2023
6 checks passed
@croyzor croyzor deleted the spec/formatting-fix branch July 28, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants