[Refactor] Derive PartialEq for ConstValue #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
changed the title
|
Apparently the error that prevents us from deriving Here's a minimal case. Hopefully it will be fixed some day... playground |
aborgna-q
approved these changes
Jul 31, 2023
acl-cqc
force-pushed
the
refactor/derive_partialeq
branch
from
d8f933c
to
2761f1d
Compare
Add extra tuple to workaround rust-lang/rust#78808 Rename CustomConst::(eq => equal_consts) to disambiguate
acl-cqc
force-pushed
the
refactor/derive_partialeq
branch
from
2761f1d
to
b6f65ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT our manual implementation does exactly what the derive one would, except for one case - ConstValue::Opaque. But with a bit of "wizardry" (?!) we can get provide that ourselves and get Rust to derive the rest.
The extra level of tupling inside
ConstValue::Opaquewas because without that thederive(serde::Serialize)on ConstValue produced a complex error about moving out of a Box. Astruct OpaqueValue(CustomType, Box<dyn CustomConst>)is one way to do that but just the tuple works too.