seal PrimType trait #296
Merged
seal PrimType trait #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
approved these changes
Jul 26, 2023
src/types/simple.rs
Outdated
| // may be updated with functions in future for necessary shared functionality | ||
| // across ClassicType, SimpleType and HashableType. | ||
| // Currently used to constrain Container<T> | ||
| /// Tells us the [TypeTag] of the type represented by the receiver. | ||
| fn tag(&self) -> TypeTag; | ||
| } | ||
|
|
||
| // sealed trait pattern to prevent users extending PrimType | ||
| mod private { |
There was a problem hiding this comment.
Just to be consistent with hugr::view::sealed
mod sealed {
ss2165
force-pushed
the
refactor/sealed-prim
branch
from
dd7eb0c
to
732d2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289