Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2 of 4] Builder operates on any HugrMut #281

Closed
wants to merge 19 commits into from
Closed

[2 of 4] Builder operates on any HugrMut #281

wants to merge 19 commits into from

Commits on Jul 24, 2023

  1. [trivial][refactor]Combine identical impl blocks for BlockBuilder

    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4bc534c View commit details
    Browse the repository at this point in the history

  2. [trivial][refactor]Combine identical impl blocks for TailLoopBuilder

    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    5dcb6c7 View commit details
    Browse the repository at this point in the history

  3. Add Container::Base{Mut,View}, define as &'a (mut) Hugr - build_trait… 

    …s broken
    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1dd1f1f View commit details
    Browse the repository at this point in the history

  4. WIP (changing region.rs - but needs impl of HugrView that view.rs doe… 

    …sn't provide)
    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    51701cc View commit details
    Browse the repository at this point in the history

  5. Expose HugrMut; add pub trait Buildable to parametrize all Builder cl… 

    …asses
    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    65e02f1 View commit details
    Browse the repository at this point in the history

  6. build_traits.rs: allow missing docs

    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e8c0d81 View commit details
    Browse the repository at this point in the history

  7. clippy (inc 1 where VSCode was wrong)

    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    5e64b0a View commit details
    Browse the repository at this point in the history

  8. Revert unnecessary test changes - from_existing(Hugr) still works

    @acl-cqc
    acl-cqc committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    8ac5c6b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Merge remote-tracking branch 'origin/main' into new/buildable_hugrmut

    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    42d5eef View commit details
    Browse the repository at this point in the history

  2. deparameterize BaseMut but return &mut; combine impl Buildable for (H… 

    …ugr/&mut H -> H); return &mut BaseMut
    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    46c35a9 View commit details
    Browse the repository at this point in the history

  3. Combine BaseMut/BaseView -> Base; remove explicit drop(!)

    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0372837 View commit details
    Browse the repository at this point in the history

  4. Buildable does not require HugrMut, but Base constrained Buildable+Hu… 

    …grMut
    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    630c216 View commit details
    Browse the repository at this point in the history

  5. Container: Buildable. Massive savings on <gunk> albeit deeper refs?

    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6ae5516 View commit details
    Browse the repository at this point in the history

  6. Buildable::Base does not need to be Buildable!

    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1742bc9 View commit details
    Browse the repository at this point in the history

  7. Drop redundant +HugrView constraint, and HugrView impl for (&impl Hug… 

    …rView)
    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2d6ebce View commit details
    Browse the repository at this point in the history

  8. <Self as Buildable>::Base -> B/T (whatever type param is)

    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    cc8f489 View commit details
    Browse the repository at this point in the history

  9. Rewrite HugrMut impl using delegate

    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    eee773c View commit details
    Browse the repository at this point in the history

  10. Impl HugrView using delegate

    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    f4cc4af View commit details
    Browse the repository at this point in the history

  11. Reinstate BaseMut<'a>: Buildable+HugrMut and BaseView<'a> -> max 1 in… 

    …direction

No blanket impl<F: Foo> Foo for &[mut] F (for Foo=HugrMut/HugrView/Buildable)
Implement Buildable for <T: AsRef<Hugr> + AsMut<Hugr>>
Buildable does not require HugrMut (too awkward as needs many impls)
Revert hugrmut.rs and view.rs to branch main
    @acl-cqc
    acl-cqc committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3cee27a View commit details
    Browse the repository at this point in the history