Use type cached in ConstValue::Opaque, remove ConstTypeError::Failed #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croyzor
reviewed
Jul 18, 2023
croyzor
reviewed
Jul 18, 2023
src/hugr/typecheck.rs
Outdated
| match (typ, val) { | ||
| (ClassicType::Int(exp_width), ConstValue::Int { value, width }) => { | ||
| let failure = Err(ConstTypeError::TypeMismatch(typ.clone(), val.const_type())); | ||
| match typ { |
There was a problem hiding this comment.
I think it would be neater to keep matching on the pair (typ, val), rather than starting every branch with a let ... else ...
There was a problem hiding this comment.
I think falling through to returning failure is also neater than returning it in the branches
There was a problem hiding this comment.
Ok, there was a goal besides neatness (that it's easy to miss a case when you match on a pair), but never mind - I did write [subjective] in the title of that commit :-) :-)
I've removed that commit so now am just dropping Failure in favour of only TypeMismatch, how's that?
acl-cqc
force-pushed
the
new/fewer_const_type_errors
branch
from
1ca3713
to
87d145f
Compare
acl-cqc
changed the title
croyzor
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typecheck_constConstTypeError::TypeMismatchgives both expected and actual type,ConstTypeError::Failedgave only the expected type. However, we always have the actual type available viaconst_type(), so we can alway use the more informative TypeMismatch error