[bugfix] Non-local edges: fix validation, Consts inside CFG, no Static Dom edges #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
commented
Jul 11, 2023
| // Inter-graph constant wires do not have restrictions | ||
| EdgeKind::Static(typ) => { | ||
| if let OpType::Const(ops::Const(val)) = from_optype { | ||
| return typecheck_const(&typ, val).map_err(ValidationError::from); | ||
| typecheck_const(&typ, val).map_err(ValidationError::from)?; |
There was a problem hiding this comment.
I do wonder if this should go in validate_operation. Admittedly there is nothing else there like it (but nor anywhere else that I can see - am I missing somewhere?)
acl-cqc
commented
Jul 11, 2023
| } else { | ||
| Err(InterGraphEdgeError::InvalidConstSrc { | ||
| if !OpTag::Function.is_superset(from_optype.tag()) { | ||
| return Err(InterGraphEdgeError::InvalidConstSrc { |
There was a problem hiding this comment.
I'm also not really sure about this check. If a node says its other port/edgekind is static, isn't that sufficient - do we really mean to restrict only const/function nodes to doing that here?
There was a problem hiding this comment.
It does actually say this in the spec but just seems a bit weird: https://github.com/CQCL-DEV/hugr/blob/main/specification/hugr.md#static-edges
acl-cqc
changed the title
cqc-alec
approved these changes
Jul 12, 2023
src/hugr/validate.rs
Outdated
| })?; | ||
| // External edge. | ||
| if !is_static { | ||
| // Must have an order edge§ |
There was a problem hiding this comment.
Suggested change
| // Must have an order edge§ | |
| // Must have an order edge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231