Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't semver-check if cargo check fails #1602

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Oct 21, 2024

Waiting for CQCL/hugrverse-actions#15 to get merged, so we don't slow down the checks too much.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (45c3106) to head (fcf6758).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1602   +/-   ##
=======================================
  Coverage   85.64%   85.64%           
=======================================
  Files         136      136           
  Lines       24918    24918           
  Branches    21854    21854           
=======================================
  Hits        21342    21342           
  Misses       2468     2468           
  Partials     1108     1108           
Flag Coverage Δ
python 92.68% <ø> (ø)
rust 84.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q marked this pull request as ready for review October 21, 2024 15:25
@aborgna-q aborgna-q requested a review from a team as a code owner October 21, 2024 15:25
@aborgna-q aborgna-q requested a review from doug-q October 21, 2024 15:25
@aborgna-q aborgna-q added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit ea0b204 Oct 22, 2024
23 checks passed
@aborgna-q aborgna-q deleted the ab/simplify-semver-checks branch October 22, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants