Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(py): allow conditional cases to be defined out of order #1599

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Oct 18, 2024

Closes #1596

Was tempted to just change the type of cases since who would be using it anyway but I've tried to be good and deprecate instead

@ss2165 ss2165 requested a review from a team as a code owner October 18, 2024 15:14
@ss2165 ss2165 requested review from acl-cqc and mark-koch and removed request for acl-cqc October 18, 2024 15:14
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.71%. Comparing base (c5b597d) to head (a15a89e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
hugr-py/src/hugr/build/cond_loop.py 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
- Coverage   85.72%   85.71%   -0.01%     
==========================================
  Files         136      136              
  Lines       24783    24793      +10     
  Branches    21719    21719              
==========================================
+ Hits        21244    21251       +7     
- Misses       2437     2440       +3     
  Partials     1102     1102              
Flag Coverage Δ
python 92.61% <80.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Closes #1596

Was tempted to just change the type of `cases` since who would be using it anyway but I've tried to be good and deprecate instead
@ss2165 ss2165 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 583d21d Oct 23, 2024
19 of 20 checks passed
@ss2165 ss2165 deleted the ss/case-bug branch October 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding cases in different order breaks builder
2 participants