Skip to content

Commit

Permalink
ci: Fix pr-title not running (#1384)
Browse files Browse the repository at this point in the history
It seems that skipping reusable workflow jobs causes inconsistent check
names between `pull_request_target` and `merge_group`.
For the non-skipped PR runs we get a `local_job/remote_job` name,
but the skipped jobs in the merge queue are just called `local_job`....
(even if skipped in the called workflow instead of locally).

I updated the reusable workflow to skip individual steps instead of the
whole job, so now we shouldn't have to deal with that inconsistency.

I will need to update the required check name to `local/remote`
  • Loading branch information
aborgna-q authored Jul 30, 2024
1 parent 0a8e258 commit 99000c5
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/pr-title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ on:

jobs:
check-title:
name: Validate Conventional Commit PR title
if: github.event_name == 'pull_request_target'
name: check-title
uses: CQCL/hugrverse-actions/.github/workflows/pr-title.yml@main
secrets:
GITHUB_PAT: ${{ secrets.HUGRBOT_PAT }}

0 comments on commit 99000c5

Please sign in to comment.