Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Sea_ice_seasonality #453

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

adele-morrison
Copy link
Collaborator

Closes #271.

Ok, I feel like I might have oversimplified this. See what you think. There used to be a section on computing the long term mean over the IAF cycle of these statistics and then yearly anomalies from that long term mean. But I have reduced the whole notebook to just dealing with a single year, so I removed that section.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!
I tested it and runs all good!

@navidcy
Copy link
Collaborator

navidcy commented Sep 1, 2024

Yes, it has less things than before but I think this is a better intro to sea-ice analysis. At least, for a non-sea ice expert like myself this feels less intimidating.

@navidcy navidcy added the 🛸 updating An existing notebook needs to be updated label Sep 1, 2024
@adele-morrison
Copy link
Collaborator Author

Shall we see if @anton-seaice or @lidefi87 have thoughts? Or should I just merge?

@navidcy
Copy link
Collaborator

navidcy commented Sep 1, 2024

Happy either way! I'll leave it to you.
We can always merge and then submit a new PR to further modify..

Personally, I'm very happy with this recipe now.

@adele-morrison
Copy link
Collaborator Author

Cool, let's merge then!

@adele-morrison adele-morrison merged commit 6a29774 into COSIMA:main Sep 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛸 updating An existing notebook needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Sea_Ice_Seasonality_Statistics.ipynb notebook
2 participants