Added JSHint to Github Workflows

.github/workflows/jshint.yaml

@@ -0,0 +1,26 @@
+name: JSHint Lint Check
+
+on:
+  push:
+    branches: [f24] # Adjust the branch as needed
+  pull_request:
+    branches: [f24]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v3
+
+    - name: Set up Node.js
+      uses: actions/setup-node@v3
+      with:
+        node-version: '22' # Specify your Node version
+
+    - name: Install dependencies
+      run: npm install
+
+    - name: Run JSHint
+      run: npx jshint src/ # Runs JSHint on all files in the repo

.gitignore

@@ -66,7 +66,6 @@ coverage
 test/files/normalise.jpg.png
 test/files/normalise-resized.jpg
 package-lock.json
-/package.json
 *.mongodb
 link-plugins.sh
 test.sh

.jshintrc

@@ -1,8 +1,11 @@
 {
-  "esversion": 6,     // To specify ES6+ support
+  "esversion": 9,     // To specify ES6+ support
   "curly": true,      // Require curly braces around blocks
   "eqeqeq": true,     // Require strict equality (=== and !==)
   "undef": true,      // Warn about undefined variables
-  "unused": true,     // Warn about unused variables
-  "node": true        // Enable Node.js global variables and scoping
+  "unused": false,     // Warn about unused variables
+  "node": true,      // Enable Node.js global variables and scoping
+  "-W018": false,
+  "-W116": false,
+  "-W083": false
 }

package.json

@@ -0,0 +1,201 @@
+{
+    "name": "nodebb",
+    "license": "GPL-3.0",
+    "description": "NodeBB Forum",
+    "version": "3.8.4",
+    "homepage": "https://www.nodebb.org",
+    "repository": {
+        "type": "git",
+        "url": "https://github.com/NodeBB/NodeBB/"
+    },
+    "main": "app.js",
+    "scripts": {
+        "start": "node loader.js",
+        "lint": "eslint --cache ./nodebb .",
+        "test": "nyc --reporter=html --reporter=text-summary mocha",
+        "coverage": "nyc report --reporter=text-lcov > ./coverage/lcov.info",
+        "coveralls": "nyc report --reporter=text-lcov | coveralls && rm -r coverage"
+    },
+    "nyc": {
+        "exclude": [
+            "src/upgrades/*",
+            "test/*"
+        ]
+    },
+    "lint-staged": {
+        "*.js": [
+            "eslint --fix"
+        ]
+    },
+    "dependencies": {
+        "@adactive/bootstrap-tagsinput": "0.8.2",
+        "@fontsource/inter": "5.0.18",
+        "@fontsource/poppins": "5.0.14",
+        "@fortawesome/fontawesome-free": "6.5.2",
+        "@isaacs/ttlcache": "1.4.1",
+        "@nodebb/spider-detector": "2.0.3",
+        "@popperjs/core": "2.11.8",
+        "@socket.io/redis-adapter": "8.3.0",
+        "ace-builds": "1.33.2",
+        "archiver": "7.0.1",
+        "async": "3.2.5",
+        "autoprefixer": "10.4.19",
+        "bcryptjs": "2.4.3",
+        "benchpressjs": "2.5.1",
+        "body-parser": "1.20.2",
+        "bootbox": "6.0.0",
+        "bootstrap": "5.3.3",
+        "bootswatch": "5.3.3",
+        "chalk": "4.1.2",
+        "chart.js": "4.4.2",
+        "cli-graph": "3.2.2",
+        "clipboard": "2.0.11",
+        "colors": "1.4.0",
+        "commander": "12.0.0",
+        "compare-versions": "6.1.0",
+        "complexity-report": "^2.0.0-alpha",
+        "compression": "1.7.4",
+        "connect-flash": "0.1.1",
+        "connect-mongo": "5.1.0",
+        "connect-multiparty": "2.2.0",
+        "connect-pg-simple": "9.0.1",
+        "connect-redis": "7.1.1",
+        "cookie-parser": "1.4.6",
+        "cron": "3.1.7",
+        "cropperjs": "1.6.2",
+        "csrf-sync": "4.0.3",
+        "daemon": "1.1.0",
+        "diff": "5.2.0",
+        "esbuild": "0.21.2",
+        "express": "4.19.2",
+        "express-session": "1.18.0",
+        "express-useragent": "1.0.15",
+        "fetch-cookie": "3.0.1",
+        "file-loader": "6.2.0",
+        "fs-extra": "11.2.0",
+        "graceful-fs": "4.2.11",
+        "helmet": "7.1.0",
+        "html-to-text": "9.0.5",
+        "imagesloaded": "5.0.0",
+        "ioredis": "5.4.1",
+        "ipaddr.js": "2.2.0",
+        "jquery": "3.7.1",
+        "jquery-deserialize": "2.0.0",
+        "jquery-form": "4.3.0",
+        "jquery-serializeobject": "1.0.0",
+        "jquery-ui": "1.13.3",
+        "jsesc": "3.0.2",
+        "json2csv": "5.0.7",
+        "jsonwebtoken": "9.0.2",
+        "lodash": "4.17.21",
+        "logrotate-stream": "0.2.9",
+        "lru-cache": "10.2.2",
+        "mime": "3.0.0",
+        "mkdirp": "3.0.1",
+        "mongodb": "6.6.1",
+        "morgan": "1.10.0",
+        "mousetrap": "1.6.5",
+        "multiparty": "4.2.3",
+        "nconf": "0.12.1",
+        "nodebb-plugin-2factor": "7.5.3",
+        "nodebb-plugin-composer-default": "10.2.36",
+        "nodebb-plugin-dbsearch": "6.2.5",
+        "nodebb-plugin-emoji": "5.1.15",
+        "nodebb-plugin-emoji-android": "4.0.0",
+        "nodebb-plugin-location-to-map": "^0.1.1",
+        "nodebb-plugin-markdown": "12.2.6",
+        "nodebb-plugin-mentions": "4.4.3",
+        "nodebb-plugin-ntfy": "1.7.4",
+        "nodebb-plugin-spam-be-gone": "2.2.2",
+        "nodebb-rewards-essentials": "1.0.0",
+        "nodebb-theme-harmony": "1.2.63",
+        "nodebb-theme-lavender": "7.1.8",
+        "nodebb-theme-peace": "2.2.6",
+        "nodebb-theme-persona": "13.3.25",
+        "nodebb-widget-essentials": "7.0.18",
+        "nodemailer": "6.9.13",
+        "nprogress": "0.2.0",
+        "passport": "0.7.0",
+        "passport-http-bearer": "1.0.1",
+        "passport-local": "1.0.0",
+        "pg": "8.11.5",
+        "pg-cursor": "2.10.5",
+        "postcss": "8.4.38",
+        "postcss-clean": "1.2.0",
+        "progress-webpack-plugin": "1.0.16",
+        "prompt": "1.3.0",
+        "rimraf": "5.0.7",
+        "rss": "1.2.2",
+        "rtlcss": "4.1.1",
+        "sanitize-html": "2.13.0",
+        "sass": "1.77.1",
+        "semver": "7.6.2",
+        "serve-favicon": "2.5.0",
+        "sharp": "0.32.6",
+        "sitemap": "7.1.1",
+        "socket.io": "4.7.5",
+        "socket.io-client": "4.7.5",
+        "sortablejs": "1.15.2",
+        "spdx-license-list": "6.9.0",
+        "terser-webpack-plugin": "5.3.10",
+        "textcomplete": "0.18.2",
+        "textcomplete.contenteditable": "0.1.1",
+        "timeago": "1.6.7",
+        "tinycon": "0.6.8",
+        "toobusy-js": "0.5.1",
+        "tough-cookie": "4.1.4",
+        "validator": "13.12.0",
+        "webpack": "5.91.0",
+        "webpack-merge": "5.10.0",
+        "winston": "3.13.0",
+        "workerpool": "9.1.1",
+        "xml": "1.0.1",
+        "xregexp": "5.1.1",
+        "yargs": "17.7.2",
+        "zxcvbn": "4.4.2"
+    },
+    "devDependencies": {
+        "@apidevtools/swagger-parser": "10.1.0",
+        "@commitlint/cli": "19.3.0",
+        "@commitlint/config-angular": "19.3.0",
+        "coveralls": "3.1.1",
+        "eslint": "8.57.0",
+        "eslint-config-nodebb": "0.2.1",
+        "eslint-plugin-import": "2.29.1",
+        "grunt": "1.6.1",
+        "grunt-contrib-watch": "1.1.0",
+        "husky": "8.0.3",
+        "jsdom": "24.0.0",
+        "jshint": "^2.13.6",
+        "lint-staged": "15.2.2",
+        "mocha": "10.4.0",
+        "mocha-lcov-reporter": "1.3.0",
+        "mockdate": "3.0.5",
+        "nyc": "15.1.0",
+        "smtp-server": "3.13.4"
+    },
+    "optionalDependencies": {
+        "sass-embedded": "1.77.1"
+    },
+    "resolutions": {
+        "*/jquery": "3.7.1"
+    },
+    "bugs": {
+        "url": "https://github.com/NodeBB/NodeBB/issues"
+    },
+    "engines": {
+        "node": ">=18"
+    },
+    "maintainers": [
+        {
+            "name": "Julian Lam",
+            "email": "[email protected]",
+            "url": "https://github.com/julianlam"
+        },
+        {
+            "name": "Barış Soner Uşaklı",
+            "email": "[email protected]",
+            "url": "https://github.com/barisusakli"
+        }
+    ]
+}

src/controllers/errors.js

@@ -40,7 +40,7 @@ exports.handleURIErrors = async function handleURIErrors(err, req, res, next) {
 
 // this needs to have four arguments or express treats it as `(req, res, next)`
 // don't remove `next`!
-exports.handleErrors = async function handleErrors(err, req, res, next) { // eslint-disable-line no-unused-vars
+exports.handleErrors = async function handleErrors(err, req, res, _next) { // eslint-disable-line no-unused-vars
 	const cases = {
 		EBADCSRFTOKEN: function () {
 			winston.error(`${req.method} ${req.originalUrl}\n${err.message}`);

src/controllers/helpers.js

@@ -485,7 +485,7 @@ helpers.formatApiResponse = async (statusCode, res, payload) => {
 			case '[[error:user-banned]]':
 				Object.assign(response, await generateBannedResponse(res));
 				// intentional fall through
-
+				break;
 			case '[[error:no-privileges]]':
 				statusCode = 403;
 				break;

src/request.js

@@ -8,9 +8,13 @@ exports.jar = function () {
 };
 
 async function call(url, method, { body, timeout, jar, ...config } = {}) {
-	let fetchImpl = fetch;
+	let fetchImpl;
 	if (jar) {
+		// jshint undef: false
 		fetchImpl = fetchCookie(fetch, jar);
+	} else {
+		// jshint undef: false
+		fetchImpl = fetch;
 	}
 
 	const jsonTest = /application\/([a-z]+\+)?json/;
@@ -23,6 +27,7 @@ async function call(url, method, { body, timeout, jar, ...config } = {}) {
 		},
 	};
 	if (timeout > 0) {
+		// jshint undef: false
 		opts.signal = AbortSignal.timeout(timeout);
 	}