Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool 3 (Static Analysis): Integrated Retire.js into our CI/CD pipeline #41

Open
wants to merge 2 commits into
base: f24
Choose a base branch
from
Open

Tool 3 (Static Analysis): Integrated Retire.js into our CI/CD pipeline #41

wants to merge 2 commits into from

Conversation

joeni21
Copy link

@joeni21 joeni21 commented Oct 23, 2024 •
edited
Loading

Integrated Retire.js static analysis tool

Evidence that it was installed: https://github.com/CMU-313/nodebb-f24-team-five-guys/pull/41/files

Evidence the tool was run on the repository (screenshot below):
Untitled

@joeni21 joeni21 added the enhancement New feature or request label Oct 23, 2024
@joeni21 joeni21 self-assigned this Oct 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11489161695

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 82.722%
Files with Coverage Reduction New Missed Lines %
src/user/approval.js 3 87.61%
Totals Coverage Status
Change from base Build 11488777020: 0.005%
Covered Lines: 22358
Relevant Lines: 25612
💛 - Coveralls

@paulinezhanghh paulinezhanghh changed the title Incorporate Retire.js as a static tool for future deployment Tool3: Integrated Retire.js as a static tool for future deployment Oct 24, 2024
@paulinezhanghh paulinezhanghh changed the title Tool3: Integrated Retire.js as a static tool for future deployment Tool 3: Integrated Retire.js as a static tool for future deployment Oct 24, 2024
@LeeMEow23 LeeMEow23 added this to the Project 3 milestone Oct 24, 2024
@joeni21 joeni21 changed the title Tool 3: Integrated Retire.js as a static tool for future deployment Tool 3: Integrated Retire.js as a static analysis tool for future deployment Oct 24, 2024
@LeeMEow23 LeeMEow23 changed the title Tool 3: Integrated Retire.js as a static analysis tool for future deployment Tool 3(static analysis): Integrated Retire.js into our CI/CD pipeline Oct 24, 2024
@LeeMEow23 LeeMEow23 changed the title Tool 3(static analysis): Integrated Retire.js into our CI/CD pipeline Tool 3 (Static Analysis): Integrated Retire.js into our CI/CD pipeline Oct 24, 2024
@e5z26 e5z26 self-requested a review October 24, 2024 21:35
e5z26
e5z26 reviewed Oct 24, 2024
View reviewed changes
Copy link

@e5z26 e5z26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that the tool is installed and running properly, but next time add the code into package.json instead of the deploy yaml file so that the tool is in the right place.

@e5z26 e5z26 removed the request for review from LeeMEow23 October 24, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5z26 e5z26 e5z26 left review comments

Assignees

@joeni21 joeni21

Labels
Analysis Tools enhancement New feature or request
Projects
None yet
Milestone
Project 3
Development

Successfully merging this pull request may close these issues.
4 participants
@joeni21 @coveralls @e5z26 @LeeMEow23