Moving install frontend step after nodebb setup in azure-deploy-f24.yml #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11491725208Details
💛 - Coveralls |
alx-zhu
added
size: s
US1: topics search bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moved install frontend step after the ./nodebb setup call as per Emma Tong's feedback on Slack.
Why?
Installing frontend before the ./nodebb setup call causes the build process to fail. Following the feedback from Emma Tong on Slack, moved the installation after the setup.
How?
Moved from line 35 to 46, which comes after the "Set up NodeBB" step.
Screenshots?
Deployed search and endorsement:
