Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endorse: Created unit tests to test the functionality of the endorsement feature #26

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

John-Crawshaw
Copy link

@John-Crawshaw John-Crawshaw commented Oct 9, 2024

WHAT

Unit tests were added to ensure that when an admin upvotes a post, the post is then endorsed. Also included tests to ensure that when non-admins upvote a test that it is not endorsed.

WHY

These tests ensure that the endorse function works as intended and is not hard coded for all posts.

Resolves: #23

HOW

We tested both admin and non-admin upvoting and down voting to make sure the proper values were passed and presented.

Tests

image

@John-Crawshaw John-Crawshaw added size: m Endorse features/changes related to admins endorsing a post US2: endorse posts Features/changes related to the endorse posts element labels Oct 9, 2024
@John-Crawshaw John-Crawshaw added this to the Sprint 2 milestone Oct 9, 2024
@John-Crawshaw John-Crawshaw self-assigned this Oct 9, 2024
Copy link

@Victor-Crawshaw Victor-Crawshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Victor-Crawshaw Victor-Crawshaw merged commit 0f930f1 into f24 Oct 9, 2024
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11261967921

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.67%

Totals Coverage Status
Change from base Build 11261657917: 0.005%
Covered Lines: 22335
Relevant Lines: 25596

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Endorse features/changes related to admins endorsing a post size: m US2: endorse posts Features/changes related to the endorse posts element
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endorse: add unit tests for endorsing posts
3 participants