Endorse: Backend changes to display endorsement next to the author of a post in a topic

.mocharc.yml

@@ -1,4 +1,4 @@
 reporter: dot
 timeout: 25000
 exit: true
-bail: true
+bail: false

public/openapi/read/topic/topic_id.yaml

@@ -184,6 +184,8 @@ get:
                           type: boolean
                         downvoted:
                           type: boolean
+                        showendorse:
+                          type: boolean
                         replies:
                           type: object
                           properties:

src/api/posts.js

@@ -337,8 +337,9 @@ postsAPI.getVoters = async function (caller, data) {
 
 	let hasAdminUpvoted = false;
 
-	for (const uid of upvoteUids) {
-		const isAdmin = groups.isMemberOfGroups(uid, ['administrators']);
+	const uidPromises = upvoteUids.map(uid => groups.isMemberOfGroups(uid, ['administrators']));
+	const results = await Promise.all(uidPromises);
+	for (const isAdmin of results) {
 		if (isAdmin[0]) {
 			hasAdminUpvoted = true;
 			break; // Exit loop as soon as an admin is found

src/posts/votes.js

@@ -8,6 +8,7 @@ const topics = require('../topics');
 const plugins = require('../plugins');
 const privileges = require('../privileges');
 const translator = require('../translator');
+const groups = require('../groups');
 
 module.exports = function (Posts) {
 	const votesInProgress = {};
@@ -83,14 +84,21 @@ module.exports = function (Posts) {
 	Posts.getVoteStatusByPostIDs = async function (pids, uid) {
 		if (parseInt(uid, 10) <= 0) {
 			const data = pids.map(() => false);
-			return { upvotes: data, downvotes: data };
+			return { upvotes: data, downvotes: data, showendorse: data };
 		}
+		const endorsements = await Promise.all(pids.map(async (pid) => {
+			const upvoteUids = await db.getSetMembers(`pid:${pid}:upvote`);
+			const uidPromises = upvoteUids.map(uid => groups.isMemberOfGroups(uid, ['administrators']));
+			const results = await Promise.all(uidPromises);
+			return results.some(isAdmin => isAdmin[0]);
+		}));
 		const upvoteSets = pids.map(pid => `pid:${pid}:upvote`);
 		const downvoteSets = pids.map(pid => `pid:${pid}:downvote`);
 		const data = await db.isMemberOfSets(upvoteSets.concat(downvoteSets), uid);
 		return {
 			upvotes: data.slice(0, pids.length),
 			downvotes: data.slice(pids.length, pids.length * 2),
+			showendorse: endorsements,
 		};
 	};
 

src/topics/posts.js

@@ -136,6 +136,7 @@ module.exports = function (Topics) {
 				postObj.bookmarked = bookmarks[i];
 				postObj.upvoted = voteData.upvotes[i];
 				postObj.downvoted = voteData.downvotes[i];
+				postObj.showendorse = voteData.showendorse[i];
 				postObj.votes = postObj.votes || 0;
 				postObj.replies = replies[i];
 				postObj.selfPost = parseInt(uid, 10) > 0 && parseInt(uid, 10) === postObj.uid;