You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored handleUploads function in public/src/admin/settings.js by unnesting functions and writing them as separate functions. resolves#541. The functions that resulted from this were : handleClick, getUploaderOption, updateTargetValue.
My coverall is failing by .005% because of a decrease in coverage in the src/meta/errors.js file. This is not a file I addressed at all in my refactoring and it is not related to my refactored code. TAs on Thursday let me know that this was ok as long as I acknowledged and explained it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored handleUploads function in public/src/admin/settings.js by unnesting functions and writing them as separate functions. resolves #541. The functions that resulted from this were : handleClick, getUploaderOption, updateTargetValue.
My coverall is failing by .005% because of a decrease in coverage in the src/meta/errors.js file. This is not a file I addressed at all in my refactoring and it is not related to my refactored code. TAs on Thursday let me know that this was ok as long as I acknowledged and explained it.