-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymous Post Full Feature #26
Conversation
Pull Request Test Coverage Report for Build 11126594669Details
💛 - Coveralls |
After encountering persistent issues with our test failing due to improper handling of tags in topic creation, the solution was identified and implemented in the create.js file. The root cause was traced back to the manner in which tags were being processed and filtered before being saved. Initially, our approach was not filtering out unauthorized tags effectively, leading to discrepancies during automated tests that checked for tag validation. By enhancing the Topics.createTags function and ensuring it accurately filtered out unauthorized tags based on user privileges and category restrictions, we resolved the test failures. We also refined the validation logic to reject any tags not explicitly allowed, which now ensures that only permissible tags are associated with any created topic. This adjustment not only fixed the failing tests but also bolstered the robustness of our topic creation process against potential misuse or errors related to tag handling. It is crucial to highlight this issue and its resolution as our group continues to work with NodeBB, as it shows us the importance of thorough validation and error handling in our code. By addressing tag filtering effectively, we ensure that our application maintains data integrity and adheres to user permissions, which is vital for fostering a safe and user-friendly environment. Moreover, understanding and documenting such challenges will help our team identify potential pitfalls in future development tasks and enhance our collaborative problem-solving skills. This serves as a valuable learning opportunity, reinforcing our commitment to writing maintainable code that aligns with best practices in software development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall It looks good,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request addresses all the unsolved issues regarding Sprint 1 in terms of the anonymous US and these specific issues:
In the previous pull requests regarding these issues: #25 and #22 attempted to solve these issues in a similar manner but had conflicts with nodeBB and the group repository in general so these solutions could not be implemented. Taking the logic of these solutions, this branch has been created to implement the full Anonymous posting feature, this included changes in the composer.js, composer-title-container.tpl and create.js.
This PR fully fixes #22 and #25 in a succinct manner.
Final thing to now do for this User Story: