Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Story 2, Best Response Backend and Frontend #62

Open
wants to merge 66 commits into
base: f24
Choose a base branch
from

Conversation

Procos12
Copy link

@Procos12 Procos12 commented Oct 9, 2024

This pull request has multiple adjustments, mostly due to delays in pulling.

Note: Frontend modified by Abdulwahab, Backend modified by Hiba

Procos12 and others added 18 commits October 1, 2024 10:13
…eration. Currently the best response button is linked to the delete posts functionality.
Limited the ability when selecting the best response to only one post(UI only, not backend)
I.E. a user will be able to mark multiple posts as the best response through the interface
…ponse.tpl

Added comments for next steps in public/src/client/topic/best-response.js
converted indentation from spaces to tabs in best-response.js
This merge is necessary to ensure posting anonymous front end changes are up to date.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11277173895

Details

  • 12 of 49 (24.49%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 82.564%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/topics/tools.js 1 2 50.0%
src/posts/topics.js 2 6 33.33%
src/topics/posts.js 1 5 20.0%
src/posts/markPostAsBest.js 4 9 44.44%
src/api/posts.js 1 7 14.29%
src/controllers/write/posts.js 1 18 5.56%
Totals Coverage Status
Change from base Build 11274127339: -0.08%
Covered Lines: 22369
Relevant Lines: 25671

💛 - Coveralls

Upon entering a topic, need to refresh to see if a post was marked as best
Upon marking another post as the best response, need to refresh to see changes
@Procos12
Copy link
Author

Resolves all issues related to user story 2
#17 #39 #40 #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment