forked from CMU-17313Q/cmu-17313q-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Story 2, Best Response Backend and Frontend #62
Open
Procos12
wants to merge
66
commits into
f24
Choose a base branch
from
best-Response
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eration. Currently the best response button is linked to the delete posts functionality.
Limited the ability when selecting the best response to only one post(UI only, not backend) I.E. a user will be able to mark multiple posts as the best response through the interface
…ponse.tpl Added comments for next steps in public/src/client/topic/best-response.js
converted indentation from spaces to tabs in best-response.js
This merge is necessary to ensure posting anonymous front end changes are up to date.
…n names to be accurate
… as best response
Procos12
requested review from
njouud
and removed request for
hibaabdullahhamad
October 9, 2024 10:44
… show the best feild being initialized to false
… true once a post is selected as best response
Pull Request Test Coverage Report for Build 11277173895Details
💛 - Coveralls |
…h topic rather than the correct post
Upon entering a topic, need to refresh to see if a post was marked as best Upon marking another post as the best response, need to refresh to see changes
This was
linked to
issues
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has multiple adjustments, mostly due to delays in pulling.
Note: Frontend modified by Abdulwahab, Backend modified by Hiba