Issue 39, midway #60
Closed
Issue 39, midway #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eration. Currently the best response button is linked to the delete posts functionality.
Limited the ability when selecting the best response to only one post(UI only, not backend) I.E. a user will be able to mark multiple posts as the best response through the interface
…ponse.tpl Added comments for next steps in public/src/client/topic/best-response.js
converted indentation from spaces to tabs in best-response.js
Pull Request Test Coverage Report for Build 11126791483Details
💛 - Coveralls |
|
Please ask any questions here or whatsapp |
|
Resolves #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a UI component for the best response
Edited the modal that appears right after clicking on mark as best response
Currently functionality of the best response button, is to delete
Only a few steps to solve #39
Created files:
src/views/modals/best-response.tpl
public/src/client/topic/best-response.js
Edited file:
node_modules/nodebb-theme-harmony/templates/partials/topic/topic-menu-list.tpl