New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring nesting code in src/user/delete.js issue #54 #88

Open

T7alabdullah wants to merge 2 commits into CMU-17313Q:f24 from T7alabdullah:refactor-sonarcloud-warnings-talal

T7alabdullah commented Sep 4, 2024 •

edited

Loading

Reworked the updateCount function and moved it to the top of the file to avoid the nesting issue and improve maintainability.

Resolves issue #54.

T7alabdullah added 2 commits

September 4, 2024 10:25


          Reworked the updateCount function and moved it to avoid the nesting i…

c5f72e6

…ssue


          added logs inthe updateCount function for testing

29cf1f3

sonarcloud bot commented Sep 4, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10706194156

Details

3 of 7 (42.86%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 82.672%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/user/delete.js	3	7	42.86%

Totals
Change from base Build 10550029021:	0.001%
Covered Lines:	22325
Relevant Lines:	25584

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet