Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the src/upgrades/1.1.1/upload_privileges.js file to resolve warnings #107

Open
wants to merge 2 commits into
base: f24
Choose a base branch
from

Conversation

graissov
Copy link

@graissov graissov commented Sep 5, 2024

This pull request reflects changes that were made to tackle the issue #104
To resolve this issue, I:

  • Refactored the upload_privileges.js file to replace deeply nested callback functions with async/await, improving code readability and maintainability.
  • Introduced helper functions to handle category and group processing in a more modular way.

Resolved #104

Copy link

sonarcloud bot commented Sep 5, 2024

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10725898708

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.666%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10550029021: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls

@graissov graissov changed the title Refactored the upload_privileges.js file to resolve warnings Refactored the src/upgrades/1.1.1/upload_privileges.js file to resolve warnings Sep 5, 2024
@graissov graissov changed the title Refactored the src/upgrades/1.1.1/upload_privileges.js file to resolve warnings Refactoring the src/upgrades/1.1.1/upload_privileges.js file to resolve warnings Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring code in src/upgrades/1.1.1/upload_privileges.js
2 participants